Created
June 22, 2011 16:03
-
-
Save christocracy/1040439 to your computer and use it in GitHub Desktop.
Fix for duplicate records being created after store.sync()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | |
| * AjaxProxy is totally borked when it comes to synchronizing records of an UPDATE or CRDATE action | |
| * NB: This hack assumes that server will return result recordset in the same order received. | |
| */ | |
| Ext.override(Ext.data.AjaxProxy, { | |
| createRequestCallback: function(request, operation, callback, scope) { | |
| var me = this; | |
| return function(options, success, response) { | |
| if (success === true) { | |
| var reader = me.getReader(), | |
| result = reader.read(response), | |
| records = result.records, | |
| length = records.length, | |
| mc = new Ext.util.MixedCollection(true, function(r) {return r.getId();}), | |
| newRec, oldRec, i; | |
| mc.addAll(operation.records); | |
| for (i = 0; i < length; i++) { | |
| newRec = records[i]; | |
| oldRec = mc.getAt(i); | |
| if (oldRec) { | |
| // HACK Set internalId of newly-read record to that of the original record. | |
| // This is so that Store can replace the original with this new version from server. | |
| newRec.internalId = oldRec.internalId; | |
| } | |
| } | |
| //</END_OF_HACK>: everything else is verbatim from AjaxProxy | |
| //see comment in buildRequest for why we include the response object here | |
| Ext.apply(operation, { | |
| response : response, | |
| resultSet: result | |
| }); | |
| operation.setCompleted(); | |
| operation.setSuccessful(); | |
| } else { | |
| me.fireEvent('exception', this, response, operation); | |
| //TODO: extract error message from reader | |
| operation.setException(); | |
| } | |
| //this callback is the one that was passed to the 'read' or 'write' function above | |
| if (typeof callback == 'function') { | |
| callback.call(scope || me, operation); | |
| } | |
| me.afterRequest(request, true); | |
| }; | |
| } | |
| }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
You should substitute line 14 with:
mc = new Ext.util.MixedCollection(true, function(r) {return r.internalId;}),
as id of oldrecords could be null when records are synced for the first time. This could be an issue if records to be created are more than one.